Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Utvide tjensteier-detalj-API med parameter for sluttbrukers fnr #386

Closed
3 tasks done
elsand opened this issue Jan 25, 2024 · 2 comments
Closed
3 tasks done

Utvide tjensteier-detalj-API med parameter for sluttbrukers fnr #386

elsand opened this issue Jan 25, 2024 · 2 comments
Assignees
@knuhau
Labels
auth Issue related to authentication / authorization
Milestone
Fullskala produksjon

Comments

@elsand
Copy link
Member

elsand commented Jan 25, 2024 •
edited by knuhau
Loading

Beskrivelse

Som fortsettelse av #322, legges det til mulighet for tjenesteeier å legge til grunn en oppgitt sluttbrukers autorisasjon for uthenting av en enkelt dialog.

Implementasjon

Samme mekanisme som i sluttbruker-API-et benyttes hvis sluttbrukers fnr oppgis, og DTO-ene dekorereres med isAuthorized=false hvis autorisasjon mangler. URL-er skal ikke omskrives.

Oppgaver
Preview Give feedback
@elsand elsand added the auth Issue related to authentication / authorization label Jan 25, 2024
@elsand elsand added this to the Pilotproduksjon milestone Jan 25, 2024
@elsand elsand added the needs consideration Requires additional consideration label Feb 19, 2024
@oskogstad oskogstad self-assigned this Feb 23, 2024
@elsand elsand removed the needs consideration Requires additional consideration label Mar 11, 2024
@oskogstad oskogstad removed their assignment Mar 18, 2024
@elsand elsand mentioned this issue Mar 25, 2024
Closed
@elsand elsand mentioned this issue Apr 15, 2024
Closed
6 tasks
oskogstad added a commit that referenced this issue Jun 5, 2024
@oskogstad
Add todo for #386
b006bf9
@oskogstad oskogstad mentioned this issue Jun 5, 2024
Merged
4 tasks
oskogstad added a commit that referenced this issue Jun 5, 2024
@oskogstad
Add todo for #386
bd59d04
@elsand elsand mentioned this issue Jul 21, 2024
Merged
4 tasks
oskogstad added a commit that referenced this issue Jul 22, 2024
@elsand @oskogstad
feat: Implement actor entity (#912)
a635fcb 
This is a rewrite of #901, taking into account the clarified
requirements in #851

## Description

* Introduces the DialogActor entity, with DB migrations (breaking)
* Replaces the strings for "performedBy" and "seenBy" with instances of
DialogActor. This should also be used for "sender" when "transmission"
is introduced.
* Adds DTOs, mappings and validations for all enduser and service owner
endpoints
* Hash service replaced with static helper, used directly in mappers
* Refactored PersonNameRegistry to PartyNameRegistry
* Implement actor name lookup if actor id is supplied
* Replaced "via serviceowner" with a simple boolean value (should be
used in #386)
* Updated seen tests (pid masking)
* Added activity log tests (pid masking)

Missing
* Updated e2e tests

## Related Issue(s)

- #851

## Verification

- [x] **Your** code builds clean without any errors or warnings
- [x] Manual testing done (required)
- [ ] Relevant automated test added (if you find this hard, leave it and
we'll help out)

## Documentation

- [ ] Documentation is updated (either in `docs`-directory, Altinnpedia
or a separate linked PR in
[altinn-studio-docs.](https://github.com/Altinn/altinn-studio-docs), if
applicable)

---------

Co-authored-by: Ole Jørgen Skogstad <skogstad@softis.net>
@knuhau knuhau self-assigned this Aug 8, 2024
@knuhau knuhau mentioned this issue Aug 16, 2024
Merged
4 tasks
@MagnusSandgren
Copy link
Collaborator

@elsand

URL-er skal ikke omskrives.

Hvorfor? Dersom sluttbruker id senders inn burde vel også urler maskeres?

@elsand
Copy link
Member Author

elsand commented Sep 1, 2024

@elsand

URL-er skal ikke omskrives.

Hvorfor? Dersom sluttbruker id senders inn burde vel også urler maskeres?

Jeg mente altså at URL-er oppgitt i attachments og actions ikke skulle omskrives.

@elsand elsand closed this as completed Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@knuhau knuhau

Labels
auth Issue related to authentication / authorization
Projects
None yet
Milestone
Fullskala produksjon
Development

No branches or pull requests
4 participants
@elsand @MagnusSandgren @oskogstad @knuhau