feat: introduce actor and consolidate seenby, performedby and sender #901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
elsand
reviewed
Jul 18, 2024
| @@ -26,8 +27,10 @@ public class DialogActivity : IImmutableEntity, IAggregateCreatedHandler, IEvent | |||
| [AggregateChild] | |||
| public DialogActivityDescription? Description { get; set; } | |||
|
|
|||
| // todo: should PerformedBy still be nullable? | |||
There was a problem hiding this comment.
No, PerformedBy was nullable as a null string indicated that the actor was the service owner. This is now indicated with an actor instance where the actorType is serviceOwner.
|
See #912 |
oskogstad
added a commit
that referenced
this pull request
Jul 22, 2024
This is a rewrite of #901, taking into account the clarified requirements in #851 ## Description * Introduces the DialogActor entity, with DB migrations (breaking) * Replaces the strings for "performedBy" and "seenBy" with instances of DialogActor. This should also be used for "sender" when "transmission" is introduced. * Adds DTOs, mappings and validations for all enduser and service owner endpoints * Hash service replaced with static helper, used directly in mappers * Refactored PersonNameRegistry to PartyNameRegistry * Implement actor name lookup if actor id is supplied * Replaced "via serviceowner" with a simple boolean value (should be used in #386) * Updated seen tests (pid masking) * Added activity log tests (pid masking) Missing * Updated e2e tests ## Related Issue(s) - #851 ## Verification - [x] **Your** code builds clean without any errors or warnings - [x] Manual testing done (required) - [ ] Relevant automated test added (if you find this hard, leave it and we'll help out) ## Documentation - [ ] Documentation is updated (either in `docs`-directory, Altinnpedia or a separate linked PR in [altinn-studio-docs.](https://github.com/Altinn/altinn-studio-docs), if applicable) --------- Co-authored-by: Ole Jørgen Skogstad <skogstad@softis.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue(s)
Verification
Documentation
docs-directory, Altinnpedia or a separate linked PR in altinn-studio-docs., if applicable)