-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Subparty forsvinner fra party-response #1226
Comments
<!--- Provide a general summary of your changes in the Title above --> ## Description <!--- Describe your changes in detail --> ## Related Issue(s) - #1226 ## Verification - [ ] **Your** code builds clean without any errors or warnings - [ ] Manual testing done (required) - [ ] Relevant automated test added (if you find this hard, leave it and we'll help out) ## Documentation - [ ] Documentation is updated (either in `docs`-directory, Altinnpedia or a separate linked PR in [altinn-studio-docs.](https://github.com/Altinn/altinn-studio-docs), if applicable) <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced new fields in the `AuthorizedParty` and `AuthorizedSubParty` types to enhance user representation and relationships. - Added a new type `AuthorizedSubParty` to support nested party structures. - **Bug Fixes** - Improved the `GetAuthorizedParties` method to return a more complex structure, including nested sub-party information. - **Refactor** - Updated class structure and inheritance for `AuthorizedParty` and `AuthorizedSubParty` to facilitate better organization and relationships. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
<!--- Provide a general summary of your changes in the Title above --> ## Description <!--- Describe your changes in detail --> ## Related Issue(s) - #1226 ## Verification - [ ] **Your** code builds clean without any errors or warnings - [ ] Manual testing done (required) - [ ] Relevant automated test added (if you find this hard, leave it and we'll help out) ## Documentation - [ ] Documentation is updated (either in `docs`-directory, Altinnpedia or a separate linked PR in [altinn-studio-docs.](https://github.com/Altinn/altinn-studio-docs), if applicable) <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Bug Fixes** - Resolved issues with the caching mechanism for retrieving authorized parties, now using direct requests to improve reliability. - **Improvements** - Enhanced clarity in the claims retrieval process for authorized resources. - Maintained robust error handling to ensure integrity in the authorization process. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
<!--- Provide a general summary of your changes in the Title above --> ## Description <!--- Describe your changes in detail --> ## Related Issue(s) - #1226 ## Verification - [ ] **Your** code builds clean without any errors or warnings - [ ] Manual testing done (required) - [ ] Relevant automated test added (if you find this hard, leave it and we'll help out) ## Documentation - [ ] Documentation is updated (either in `docs`-directory, Altinnpedia or a separate linked PR in [altinn-studio-docs.](https://github.com/Altinn/altinn-studio-docs), if applicable)
<!--- Provide a general summary of your changes in the Title above --> ## Description <!--- Describe your changes in detail --> ## Related Issue(s) - #1226 ## Verification - [ ] **Your** code builds clean without any errors or warnings - [ ] Manual testing done (required) - [ ] Relevant automated test added (if you find this hard, leave it and we'll help out) ## Documentation - [ ] Documentation is updated (either in `docs`-directory, Altinnpedia or a separate linked PR in [altinn-studio-docs.](https://github.com/Altinn/altinn-studio-docs), if applicable)
<!--- Provide a general summary of your changes in the Title above --> ## Description <!--- Describe your changes in detail --> ## Related Issue(s) - #1226 ## Verification - [ ] **Your** code builds clean without any errors or warnings - [ ] Manual testing done (required) - [ ] Relevant automated test added (if you find this hard, leave it and we'll help out) ## Documentation - [ ] Documentation is updated (either in `docs`-directory, Altinnpedia or a separate linked PR in [altinn-studio-docs.](https://github.com/Altinn/altinn-studio-docs), if applicable) <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Bug Fixes** - Removed unnecessary logging and reflection in cache handling, simplifying error management. - Temporarily disabled setting of sub-parties in the party flattening logic for ongoing development. - **Chores** - Removed the "Serilog" logging configuration from the app settings, streamlining the configuration file. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
<!--- Provide a general summary of your changes in the Title above --> ## Description <!--- Describe your changes in detail --> Enables [AutoClone](ZiggyCreatures/FusionCache#279) feature in FusionCache ## Related Issue(s) - #1226 ## Verification - [x] **Your** code builds clean without any errors or warnings - [x] Manual testing done (required) - [ ] Relevant automated test added (if you find this hard, leave it and we'll help out) ## Documentation - [ ] Documentation is updated (either in `docs`-directory, Altinnpedia or a separate linked PR in [altinn-studio-docs.](https://github.com/Altinn/altinn-studio-docs), if applicable) <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced a new property, `EnableAutoClone`, in the caching configuration to enhance cache management. - **Bug Fixes** - Activated the assignment of an empty list to the `SubParties` property, ensuring no sub-parties are included in the authorized parties result. - **Style** - Minor formatting adjustments made for improved readability in the caching configuration. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
@LeifHelstad Ah, glemte å oppdatere saken her med hvordan reprodusere. 100% repro var:
Kunne hende at du kun fikk feil annenhvert kall om du gjentok steg 3. Kom an på om det var flere replicas av containerene kjørende. |
Test: Velger bruker Ask Uglesett 12907499179 som har en del parties og sub-parties som bør vises: Kjører testen via arbeidsflate, som jeg da oppfyller kravet om at alle kall i 1. 2 og 3 gjøres av samme bruker i samme API. Observerer;
Oppretter en dialog så jeg har noe å lage søk på som gir treff i steg 2 Steg 2: Venter fra 10:53 |
Etter vent så fremkommer alle aktører som før. Gjør derfor en ny 2 nå, men kysser så ut søkekriterier før jeg starter ventetiden (11:48). |
Også etter denne varianten fremkommer alle aktører som før. Får ikke gjenskapt beskrevet problem via arbeidsflate og anser testen som Passed. |
Symptomer
Subparty urn:altinn:organization:identifier-no:910519794 for bruker "forsvinner" fra responsen til parties-query. Etter stale time på ca 5 minutter, dukker sub party opp igjen, kun ved én fetch, deretter forsvinner det igjen. Har kun opplevd én gang å få subparty i liste over konsekutive fetches (torsdag i 1605-tiden)
Funn
Innlogget bruker 07117000413 EDEL REISERSEN
Opprettet dialog med id 019256a5-38ea-7095-9664-543168df9796
returnerer tom liste, mens f.eks.
returnerer dialog.
The text was updated successfully, but these errors were encountered: