Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebAPI returns 500 error when using existing entity IDs #959

Closed
oskogstad opened this issue Aug 2, 2024 · 0 comments · Fixed by #962
Closed

WebAPI returns 500 error when using existing entity IDs #959

oskogstad opened this issue Aug 2, 2024 · 0 comments · Fixed by #962
Assignees
@oskogstad
Labels
bug Something isn't working

Comments

@oskogstad
Copy link
Collaborator

Reproduction

Create a dialog with a transmission and/or activity
GET this dialog, and copy the transmission/activity ID

Create a new dialog, but set the transmission/activity ID to the one from the GET

Expected behavior

HTTP 422

Actual behavior

HTTP 500
@oskogstad oskogstad added the bug Something isn't working label Aug 2, 2024
@oskogstad oskogstad self-assigned this Aug 2, 2024
@oskogstad oskogstad mentioned this issue Aug 2, 2024
Merged
oskogstad added a commit that referenced this issue Aug 5, 2024
@oskogstad
fix: Using existing transmission/activity IDs should return HTTP 422 (#…
01789b1 
…960)

Introduced a bug when implementing Transmissions, changed the existing
activities check to only check on the dialog.
Reverted to check the entire table.

Also added the same check that was missing for Transmission IDs

## Related Issue(s)

- #959
@dialogporten-bot dialogporten-bot mentioned this issue Aug 5, 2024
Merged
oskogstad added a commit that referenced this issue Aug 8, 2024
@dialogporten-bot @oskogstad
chore(main): release 1.11.0 (#962)
04e1541 
🤖 I have created a release *beep* *boop*
---


##
[1.11.0](v1.10.0...v1.11.0)
(2024-08-08)


### Features

* **azure:** scaffold ssh jumper
([#958](#958))
([6228aa2](6228aa2))


### Bug Fixes

* Correct the SeenLog list endpoints OpenAPI description
([#976](#976))
([f6ebd19](f6ebd19))
* Using existing transmission/activity IDs should return HTTP 422
([#960](#960))
([01789b1](01789b1)),
closes [#959](#959)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: Ole Jørgen Skogstad <skogstad@softis.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oskogstad oskogstad

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(main): release 1.11.0 Altinn/dialogporten
1 participant
@oskogstad