Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Using existing transmission/activity IDs should return HTTP 422 #960

Merged
merged 3 commits into from
Aug 5, 2024

Conversation

oskogstad
Copy link
Collaborator

@oskogstad oskogstad commented Aug 2, 2024

Introduced a bug when implementing Transmissions, changed the existing activities check to only check on the dialog.
Reverted to check the entire table.

Also added the same check that was missing for Transmission IDs

Related Issue(s)

Copy link

sonarqubecloud bot commented Aug 4, 2024

@oskogstad oskogstad marked this pull request as ready for review August 4, 2024 11:37
@oskogstad oskogstad requested a review from a team as a code owner August 4, 2024 11:37
@oskogstad oskogstad merged commit 01789b1 into main Aug 5, 2024
19 checks passed
@oskogstad oskogstad deleted the chore/fix-broken-existing-db-key-checks branch August 5, 2024 10:36
oskogstad added a commit that referenced this pull request Aug 8, 2024
🤖 I have created a release *beep* *boop*
---


##
[1.11.0](v1.10.0...v1.11.0)
(2024-08-08)


### Features

* **azure:** scaffold ssh jumper
([#958](#958))
([6228aa2](6228aa2))


### Bug Fixes

* Correct the SeenLog list endpoints OpenAPI description
([#976](#976))
([f6ebd19](f6ebd19))
* Using existing transmission/activity IDs should return HTTP 422
([#960](#960))
([01789b1](01789b1)),
closes [#959](#959)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: Ole Jørgen Skogstad <skogstad@softis.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants