Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add idempotentId #1638
base: main
Are you sure you want to change the base?
feat: Add idempotentId #1638
Changes from 19 commits
6c94a09
5c9334d
4041dd3
fac9a18
c84485a
def7f0a
3661f12
04dec21
510b0e9
7650083
13e370b
0a7e7f7
84169fc
5ccd0d5
bd3e2f9
3a2422b
78f0d20
3d9c6db
f9fe516
4eee9ec
a92f270
4635d21
3524d7e
2b61954
346a694
3e66899
9f846c7
d4b32ce
9fb5399
a5c0ab5
72e11e5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: The order of the checks should probably match that of the composite index definition. However, as we're using a simple comparison, the order of the checks here should be handled by the optimizer in PostgreSQL such that it doesn't make any difference. For a inequality check (>, <, BETWEEN), the order would be significant, so I think it's generally best to always match the order.