Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bench): improve bench mark logs, test logger benchmark impact #942

Merged
merged 2 commits into from
Mar 16, 2023

Conversation

alimd
Copy link
Member

@alimd alimd commented Mar 16, 2023

No description provided.

@alimd alimd added the new-feature New features or options. label Mar 16, 2023
@alimd alimd self-assigned this Mar 16, 2023
@alimd alimd merged commit 96b49ab into next Mar 16, 2023
@alimd alimd deleted the feat/bench branch March 16, 2023 19:44
return userList;
};

function test_without_logger(obj: Record<string, unknown>): number {

Check failure

Code scanning / ESLint

Enforce camelcase naming convention

Identifier 'test_without_logger' is not in camel case.
return Object.values(obj).length;
}

function test_with_logger(obj: Record<string, unknown>): number {

Check failure

Code scanning / ESLint

Enforce camelcase naming convention

Identifier 'test_with_logger' is not in camel case.
Copy link
Member

@njfamirm njfamirm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

باید برم یاد بگیرم!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
new-feature New features or options.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants