Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bench): improve bench mark logs, test logger benchmark impact #942

Merged
merged 2 commits into from
Mar 16, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 13 additions & 11 deletions demo/es-bench/bench.ts
Original file line number Diff line number Diff line change
@@ -1,12 +1,14 @@
import {delay} from '@alwatr/util';

import type {MaybePromise} from '@alwatr/type';

export async function bench(name: string, func: () => MaybePromise<void>): Promise<void> {
await delay(1_000);
console.time(name);
for (let i = 100_000; i; i--) {
await func();
export const bench = (name: string, func: () => void): void => {
globalThis.gc?.();
const startMemory = process.memoryUsage.rss();
const startTime = performance.now();
for (let i = 1_000_000; i; i--) {
func();
}
console.timeEnd(name);
}
const duration = performance.now() - startTime;
const runPerSec = Math.round( 1_000_000 / duration * 1000);
const memoryUsage = Math.round((process.memoryUsage.rss() - startMemory) / 10) / 100;

console.log(`run ${name} ${runPerSec.toLocaleString()}/s with ${memoryUsage.toLocaleString()}kb`);
globalThis.gc?.();
};
7 changes: 4 additions & 3 deletions demo/es-bench/for-in-vs-of.ts
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,10 @@ function test_for_of_keys(): void {
}

prepare();
await bench('for-in', test_for_in);
await bench('for-of-values', test_for_of_values);
await bench('for-of-keys', test_for_of_keys);

bench('for-of-values', test_for_of_values);
bench('for-of-keys', test_for_of_keys);
bench('for-in', test_for_in);

globalThis.document?.body.append(' Done. Check the console.');

Expand Down
41 changes: 41 additions & 0 deletions demo/es-bench/logger.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
/* eslint-disable camelcase */

import {createLogger} from '@alwatr/logger';
// import {delay} from '@alwatr/util';

import {bench} from './bench.js';

const logger = createLogger('logger-bench', null, false);

const getUserList = (): Record<string, Record<string, string>> => {
const userList: Record<string, Record<string, string>> = {};
for (let i = 10; i; i--) {
const userId = 'user_' + i;
userList[userId] = {
user: userId,
fname: 'ali',
lname: 'md',
email: 'i@ali.md',
token: '1234abcd',
};
}
return userList;
};

function test_without_logger(obj: Record<string, unknown>): number {

Check failure

Code scanning / ESLint

Enforce camelcase naming convention

Identifier 'test_without_logger' is not in camel case.
return Object.values(obj).length;
}

function test_with_logger(obj: Record<string, unknown>): number {

Check failure

Code scanning / ESLint

Enforce camelcase naming convention

Identifier 'test_with_logger' is not in camel case.
logger.logMethodArgs('test_with_logger', obj);
return Object.values(obj).length;
}

bench('test_with_logger 1st', () => test_with_logger(getUserList()));
bench('test_without_logger 1st', () => test_without_logger(getUserList()));

bench('test_with_logger 2nd', () => test_with_logger(getUserList()));
bench('test_without_logger 2nd', () => test_without_logger(getUserList()));


globalThis.document?.body.append(' Done. Check the console.');