-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(bench): improve bench mark logs, test logger benchmark impact #942
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,14 @@ | ||
import {delay} from '@alwatr/util'; | ||
|
||
import type {MaybePromise} from '@alwatr/type'; | ||
|
||
export async function bench(name: string, func: () => MaybePromise<void>): Promise<void> { | ||
await delay(1_000); | ||
console.time(name); | ||
for (let i = 100_000; i; i--) { | ||
await func(); | ||
export const bench = (name: string, func: () => void): void => { | ||
globalThis.gc?.(); | ||
const startMemory = process.memoryUsage.rss(); | ||
const startTime = performance.now(); | ||
for (let i = 1_000_000; i; i--) { | ||
func(); | ||
} | ||
console.timeEnd(name); | ||
} | ||
const duration = performance.now() - startTime; | ||
const runPerSec = Math.round( 1_000_000 / duration * 1000); | ||
const memoryUsage = Math.round((process.memoryUsage.rss() - startMemory) / 10) / 100; | ||
|
||
console.log(`run ${name} ${runPerSec.toLocaleString()}/s with ${memoryUsage.toLocaleString()}kb`); | ||
globalThis.gc?.(); | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
/* eslint-disable camelcase */ | ||
|
||
import {createLogger} from '@alwatr/logger'; | ||
// import {delay} from '@alwatr/util'; | ||
|
||
import {bench} from './bench.js'; | ||
|
||
const logger = createLogger('logger-bench', null, false); | ||
|
||
const getUserList = (): Record<string, Record<string, string>> => { | ||
const userList: Record<string, Record<string, string>> = {}; | ||
for (let i = 10; i; i--) { | ||
const userId = 'user_' + i; | ||
userList[userId] = { | ||
user: userId, | ||
fname: 'ali', | ||
lname: 'md', | ||
email: 'i@ali.md', | ||
token: '1234abcd', | ||
}; | ||
} | ||
return userList; | ||
}; | ||
|
||
function test_without_logger(obj: Record<string, unknown>): number { | ||
return Object.values(obj).length; | ||
} | ||
|
||
function test_with_logger(obj: Record<string, unknown>): number { | ||
Check failure Code scanning / ESLint Enforce camelcase naming convention
Identifier 'test_with_logger' is not in camel case.
|
||
logger.logMethodArgs('test_with_logger', obj); | ||
return Object.values(obj).length; | ||
} | ||
|
||
bench('test_with_logger 1st', () => test_with_logger(getUserList())); | ||
bench('test_without_logger 1st', () => test_without_logger(getUserList())); | ||
|
||
bench('test_with_logger 2nd', () => test_with_logger(getUserList())); | ||
bench('test_without_logger 2nd', () => test_without_logger(getUserList())); | ||
|
||
|
||
globalThis.document?.body.append(' Done. Check the console.'); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check failure
Code scanning / ESLint
Enforce camelcase naming convention