fix: wait for language to be loaded before update #1969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 7538110. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
kpanot
approved these changes
Jul 16, 2024
| @@ -65,9 +65,10 @@ export class OtterLocalizationDevtools { | |||
| * @param keyValues key/values to update | |||
| * @param language if not provided, the current language value | |||
| */ | |||
| public updateLocalizationKeys(keyValues: { [key: string]: string }, language?: string): void | Promise<void> { | |||
| public async updateLocalizationKeys(keyValues: { [key: string]: string }, language?: string) { | |||
There was a problem hiding this comment.
Not really a big deal but a small breaking change here :D
fpaul-1A
approved these changes
Jul 16, 2024
cpaulve-1A
force-pushed
the
fix/localization-reload
branch
from
aa6e854
to
7538110
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Devtool state reload fails because the update localization message is sent before the reload of the language.