Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: wait for language to be loaded before update #1969

Merged
merged 1 commit into from
Jul 16, 2024
Merged

fix: wait for language to be loaded before update #1969

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions packages/@o3r/localization/src/devkit/localization-devtools.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { ApplicationRef, Injectable } from '@angular/core';
import { TranslateCompiler } from '@ngx-translate/core';
import { lastValueFrom, Subscription } from 'rxjs';
import {firstValueFrom, lastValueFrom, Subscription} from 'rxjs';
import { LocalizationService } from '../tools';
import type { TranslateMessageFormatLazyCompiler } from '../core';

Expand Down Expand Up @@ -65,9 +65,10 @@ export class OtterLocalizationDevtools {
* @param keyValues key/values to update
* @param language if not provided, the current language value
*/
public updateLocalizationKeys(keyValues: { [key: string]: string }, language?: string): void | Promise<void> {
public async updateLocalizationKeys(keyValues: { [key: string]: string }, language?: string) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really a big deal but a small breaking change here :D

const lang = language || this.getCurrentLanguage();
const translateService = this.localizationService.getTranslateService();
await firstValueFrom(translateService.getTranslation(lang));
Object.entries(keyValues).forEach(([key, value]) => {
translateService.set(key, value, lang);
});
Expand Down
Loading