Eslint/Prettier Configuration Proposal

[rori4]

I have created an example configuration for eslit/prettier to be integrated with the project. The configuration is set only through the .eslintrc and uses prettier for formatting.

Why use prettier with eslint?
Eslint does a poor job in autofix / autoformat of code style. The following styles give only warnings from eslint => max-len, no-mixed-spaces-and-tabs, keyword-spacing, comma-style...
https://prettier.io/docs/en/comparison.html
prettier/prettier-eslint#101 (comment)

Also I moved the eslint config dependencies to dev-dependencies and added the following scripts:

• "lint": "eslint src/**/*.{js,jsx} && echo Linting check finished",
  

• "lint:fix": "eslint --fix src/**/*.{js,jsx} && echo Linting fix finished",
  

• "eslint-check": "eslint --print-config src/App.js | eslint-config-prettier-check"
  

the lint script will check the src folder with the linter and the lint:fix will autofix / format with prettier and eslint the code when possible.

the eslint-check script will show if there are settings conflicts between prettier and eslint. Style configurations should be set with prettier here as they might cause conflict. for example "indent": ["error", "tab"], is one setting that might cause conflict if set with eslint. Running this script will show the conflicts and they can easily be removed

We can also use pretty-quick library to do linting always before commits. This way we will always have consistently styled code.

Let me know what you think.

[ivopaunov]

OK, thats great.
As I told you, I want to merge counterfactual-accounts first before doing this.
I'll try to merge this into the the other branch and if there are no conflicts I'll merge this into master.

[ivopaunov]

Can you push hust the updated package.json, eslintrc.json, and package-lock.json.
I'll try to merged it this way because now I have tons of conflicts.

[ivopaunov]

#140