Eslint/Prettier Configuration Proposal (Config Only)

[rori4]

I have created an example configuration for eslit/prettier to be integrated with the project. The configuration is set only through the .eslintrc and uses prettier for formatting.

Why use prettier with eslint?
Eslint does a poor job in autofix / autoformat of code style. The following styles give only warnings from eslint => max-len, no-mixed-spaces-and-tabs, keyword-spacing, comma-style...
https://prettier.io/docs/en/comparison.html
prettier/prettier-eslint#101 (comment)

Also I moved the eslint config dependencies to dev-dependencies and added the following scripts:

• "lint": "eslint src/**/*.{js,jsx} && echo Linting check finished",
  

• "lint:fix": "eslint --fix src/**/*.{js,jsx} && echo Linting fix finished",
  

• "eslint-check": "eslint --print-config src/App.js | eslint-config-prettier-check"
  

the lint script will check the src folder with the linter and the lint:fix will autofix / format with prettier and eslint the code when possible.

the eslint-check script will show if there are settings conflicts between prettier and eslint. Style configurations should be set with prettier here as they might cause conflict. for example "indent": ["error", "tab"], is one setting that might cause conflict if set with eslint. Running this script will show the conflicts and they can easily be removed

We can also use pretty-quick library to do linting always before commits. This way we will always have consistently styled code.

Let me know what you think.

[ivopaunov]

Put src/**/*.{js,jsx} in single quotes because it is not working on mac.
I'll merge it as soon as cf accounts are ready

[rori4]

@ivopaunov It is not working with quotes on my Windows machine. I am getting an error when I use it with quotes. Any suggestions?
http://prntscr.com/ouql9q

[rori4]

added the scripts with escapes like this. Will this work on MacOS?

 "lint": "eslint \"src/**/*.{js,jsx}\" && echo Linting check finished",
 "lint:fix": "eslint --fix \"src/**/*.{js,jsx}\" && echo Linting fix finished",