Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup cargo deny #133

Merged
merged 7 commits into from
Jul 7, 2023
Merged

Setup cargo deny #133

merged 7 commits into from
Jul 7, 2023

Conversation

Lohann
Copy link
Collaborator

@Lohann Lohann commented Jul 3, 2023

Description

This PR configures cargo-deny in the project, cargo-deny is a cargo plugin that lets you lint your project's dependency graph to ensure all your dependencies conform to your expectations and requirements.

This tool also detect crate license compliance, which is useful when the project become open-source. While configuring it I've found some issues:

Checklist

  • Configure cargo-deny
  • Configure cargo-deny on CI pipeline

The fix for the security vulnerabilities should be handle in another PR.

Type of change

  • New feature (non-breaking change which adds functionality)

Tests

Install cargo-deny tool:

cargo install cargo-deny

Then run cargo-deny checks:

cargo deny check

Code review prechecks:

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Inline comments have been added for each method
  • I have made corresponding changes to the documentation
  • Code changes introduces no new problems or warnings
  • Test cases have been added
  • Dependent changes have been merged and published in downstream modules

@Lohann Lohann requested a review from dvc94ch July 3, 2023 21:01
.gitignore Outdated Show resolved Hide resolved
@Lohann Lohann changed the title Feature/configure cargo deny Setup cargo deny Jul 3, 2023
@Lohann
Copy link
Collaborator Author

Lohann commented Jul 3, 2023

Hmm, I have no clue why the rosetta-wallet test failed, I haven't touch the code in this PR.

@dvc94ch
Copy link
Contributor

dvc94ch commented Jul 3, 2023

Yeah, some tests are broken for some chains in ci, mostly me being lazy

.gitignore Outdated Show resolved Hide resolved
@Lohann Lohann merged commit 20afba2 into master Jul 7, 2023
@dvc94ch dvc94ch deleted the feature/configure-cargo-deny branch September 7, 2023 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants