Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync master from fork #12

Merged
merged 110 commits into from
Jul 12, 2024
Merged

Sync master from fork #12

merged 110 commits into from
Jul 12, 2024

Conversation

AndreSand
Copy link
Owner

DO NOT CREATE A PULL REQUEST WITHOUT READING THESE INSTRUCTIONS

Instructions

Thanks for submitting a pull request. To accept your pull request we need you do a few things:

If this is your first pull request

Ensure tests pass and code is formatted correctly

  • Run local tests on the DemoDebug variant by running ./gradlew testDemoDebug
  • Fix code formatting: ./gradlew --init-script gradle/init.gradle.kts spotlessApply

Add a description

We need to know what you've done and why you've done it. Include a summary of what your pull request contains, and why you have made these changes. Include links to any relevant issues which it fixes.

Here's an example.

NOW DELETE THIS LINE AND EVERYTHING ABOVE IT

What I have done and why

<add your PR description here>

thatfiredev and others added 30 commits October 31, 2023 21:26
…e-firebase-ktx

# Conflicts:
#	gradle/libs.versions.toml
* main:
  Fix action name and version
  Apply spotless automatically during build and commit back to PR
  Fix #1008: Use capitalized variant name when registering gradle tasks

Change-Id: I32f6dc608179586357ed017ae35a05ca97389559
Change-Id: I45584350fe01bed54094780d3fc86b7d271d5709
Change-Id: I1fd3eb6ed0158a80511bc75d315d99d8650f5a6e
Change-Id: Ibddc1a0635a557e4432a77f2dbb032c519bf4b5a
Change-Id: I59b0f94760e99fd29ed61a29c56e2cead48b3e19
Change-Id: Ia90a4aad72db737455b70de9b4583689d6a0e5d6
Change-Id: Ibe71c285708ffec85520a0c7852600f361ed1646
…in modules

https://firebase.google.com/docs/android/kotlin-migration

Requirements: Firebase BoM 32.5.0, but let's update to the latest 32.6.0.

And remove warnings:
- `'logEvent(String, ParametersBuilder.() -> Unit): Unit' is deprecated. Migrate to use the KTX API from the main module: https://firebase.google.com/docs/android/kotlin-migration.`
- `'param(String, String): Unit' is deprecated. Migrate to use the KTX API from the main module: https://firebase.google.com/docs/android/kotlin-migration.`
See #1006 for these new permissions and "Ad Services" property.
The notification icons are now stored in `:core:notifications`.
This forces `:sync:work` to depend on it.
Another solution could be to provide the resource id through Hilt, but it would require more changes.
This is a followup cleanup of #1163 that was partially addressed by #1140.

- Remove unused `projects.core.testing` dependencies (or replace with direct dependencies).
- Introduce `androidx.compose.ui.test` bundle.
- Remove `NiaTestRunner` from the default config, forcing consumers to depend on it, even when not used.
Using latest graphviz 10.0.1
The change was an internal version name contained in a comment.
dturner and others added 29 commits July 2, 2024 17:47
…ic-robolectric-4.12.2

Bump org.robolectric:robolectric from 4.11.1 to 4.12.2
….uiautomator-uiautomator-2.3.0

Bump androidx.test.uiautomator:uiautomator from 2.2.0 to 2.3.0
Migrate legacy Gradle actions to the new official `gradle/actions`
Change-Id: I2c63da1aa2ef0bfadb7fa88a2502dbc3551e7527
Change-Id: I3432d5387da4a3bc3432723054a3ccb60abc4a46
Change-Id: I7be80c44205f7e4afcdd9e52eef42b5e9c6155e7
upgrade to Firebase BoM 32.5.0 and remove Firebase KTX
Prep work for JVM alternatives to modules/plugins
Change-Id: I084f98af8f7eb739be1053428593a2b880ae33f9
Firebase: Migrate to using the Kotlin extensions (KTX) APIs in the main modules
* Instrumented tests for InterestsListDetailScreen

Change-Id: I0325cea93bf1e1dc0b8d1fc56434d5413caf6fea

* Use BackHandler instead of asserting an Espresso exception

Change-Id: I6246fcdd51d09a609733fd83223f6d7b8c0cb6c1

* Workaround to make adaptive info use size override

currentWindowAdaptiveInfo() is not affected by using the ForcedSize
override, so the list detail scaffold directve will be calculated with
non-overridden values. This work around hoists the WindowAdaptiveInfo
so that we can pass in an appropriate value in tests.

Change-Id: Ieef99f6d710ddb70243ac5105aa7805dd638ccf8

* Spotless fixes

Change-Id: I7d8a0b3e2667ced3d73fc4f028d11823cda15455

* Review fixes

Change-Id: Iffd288c9a927f13069580c66a6ee3150abb63682

* Helper function to get topics

Change-Id: If336c4b9dac82382daf96284533a277cc58984fa
Remove Firebase AD_SERVICE_CONFIG property
@AndreSand AndreSand merged commit 954cf72 into AndreSand:main Jul 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants