-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update module dependency graphs and add script to create them #1257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I7b2ae264ec84491c847a44869934e2f238564c31
Change-Id: Ibec84b6b58d8e7911057da046bbebddcc32ceb01
Change-Id: I611f73d59790bde240756e8016aa721a1783335f
jdkoren
approved these changes
Mar 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall
Change-Id: I9c825c142799cdbb99890d49ded067427cf9fee8
Change-Id: Ifb4b44e67df53ddd8ed048122c6c12a904e61528
3 tasks
Closed
Closed
This was referenced Jul 12, 2024
This was referenced Sep 7, 2024
ghost
mentioned this pull request
Sep 29, 2024
Closed
This was referenced Sep 30, 2024
This was referenced Oct 7, 2024
Closed
This was referenced Dec 1, 2024
This was referenced Dec 10, 2024
Open
This was referenced Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I have done and why
To run the script, execute the following command in the project's root folder:
./generateModuleGraphs.sh --exclude-module :benchmarks --exclude-module :lint --exclude-module :ui-test-hilt-manifest
The
--exclude-module
parameter is used to exclude modules which don't appear in the root dependency graph (orphaned modules, only used by external programs, like CI or Android Studio)Related issues/PRs:
#1088
#707
Future work
Nice to haves:
dot -s
for scaling but didn't work.