Skip to content

Commit

Permalink
add RBAC fix to namespaces - get, watch, list to each gateway-*route (k…
Browse files Browse the repository at this point in the history
…ubernetes-sigs#4205)

* add RBAC fix to namespaces - get, watch, list to each gateway-*route

* fix conflicts

* resolve conflicts

* Apply suggestions from code review

Co-authored-by: Steve Hipwell <steve.hipwell@gmail.com>

---------

Co-authored-by: Steve Hipwell <steve.hipwell@gmail.com>
  • Loading branch information
2 people authored and AndrewCharlesHay committed Feb 7, 2024
1 parent 61215d2 commit b15fd84
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
2 changes: 2 additions & 0 deletions charts/external-dns/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Fixed

- Fixed support for gateway-grpcroute, gateway-tlsroute, gateway-tcproute, gateway-udproute
https://github.com/kubernetes-sigs/external-dns/issues/3845
- Fix args for webhook deployment. ([#4202](https://github.com/kubernetes-sigs/external-dns/pull/4202))

## [v1.14.2] - 2024-01-22
Expand Down
8 changes: 3 additions & 5 deletions charts/external-dns/templates/clusterrole.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -59,17 +59,15 @@ rules:
- apiGroups: ["gateway.networking.k8s.io"]
resources: ["gateways"]
verbs: ["get","watch","list"]
- apiGroups: [""]
resources: ["namespaces"]
verbs: ["get","watch","list"]
{{- end }}
{{- if has "gateway-httproute" .Values.sources }}
- apiGroups: ["gateway.networking.k8s.io"]
resources: ["httproutes"]
verbs: ["get","watch","list"]
{{- end }}
{{- if has "gateway-httproute" .Values.sources }}
- apiGroups: [""]
resources: ["namespaces"]
verbs: ["get","watch","list"]
{{- end }}
{{- if has "gateway-grpcroute" .Values.sources }}
- apiGroups: ["gateway.networking.k8s.io"]
resources: ["grpcroutes"]
Expand Down

0 comments on commit b15fd84

Please sign in to comment.