forked from drizzle-team/drizzle-orm
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bringing this PR up to date #2
Open
DianomiJH
wants to merge
296
commits into
Angelelz:feat-allow-subqueries-in-selectedfields
Choose a base branch
from
DianomiJH:feat-allow-subqueries-in-selectedfields
base: feat-allow-subqueries-in-selectedfields
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
bringing this PR up to date #2
DianomiJH
wants to merge
296
commits into
Angelelz:feat-allow-subqueries-in-selectedfields
from
DianomiJH:feat-allow-subqueries-in-selectedfields
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Pg] FIX: correct string escaping for empty PgArrays
…speed-improvements Added improvements to the planescale relational tests
[SQLite] Add expo-sqlite driver
…izzle-orm into extend-with-clause
Improve `with` clause
…id losing millisecond precision
My previous changes in test file broke a couple tests. I've fixed this now
…ue-issue [Pg] Add insert/update array support in aws-data-api
…ession-all Fix session.all result in AWS Data API driver
Add if method to conditionally include part of the query
…ow-subqueries-in-selectedfields
Anything holding this up from being merged? We could really use it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @Angelelz, hope you don't mind but i'm trying to bring this PR up to date in an attempt to get it merged. All I've done is pull main and update */dialect.ts to use the latest Subquery structure. This is my first time contributing to Drizzle so 🤞 i didn't break anything too bad