Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix 8-letter codes for dirs #48

Merged
merged 4 commits into from
Jun 27, 2023
Merged

chore: fix 8-letter codes for dirs #48

merged 4 commits into from
Jun 27, 2023

Conversation

AngryMaciek
Copy link
Owner

@AngryMaciek AngryMaciek commented Jun 27, 2023

Proposed changes ⤴️

Get rid of the dir-code constraint once and for all, hopefully, use 8-letter codes, should be enough.

Types of changes 🔧

What type of changes does your code introduce to the warlock?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation updated
  • Testing updated
  • Codebase refactoring
  • Other

Checklist ✅

If you're unsure about any of those below, ask explicitly.
This is simply a reminder of what needs to be checked before merging your code.

  • I have read the CONTRIBUTING.
  • I have performed a self-review of my own code.
  • I have added necessary documentation (if appropriate).
  • My changes generate no new warnings.
  • I have commented my code, particularly in hard-to-understand areas.

@AngryMaciek AngryMaciek added the good first issue Good for newcomers label Jun 27, 2023
@AngryMaciek AngryMaciek self-assigned this Jun 27, 2023
@AngryMaciek AngryMaciek merged commit 78ffded into master Jun 27, 2023
4 checks passed
@AngryMaciek AngryMaciek deleted the adjust-dir-codes branch June 27, 2023 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant