Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Starting node from a snapshot fails if the node has no blocks #1228

Closed
RalfWeinand opened this issue Jun 3, 2023 · 1 comment · Fixed by #1285, #1298, #1299 or #1304
Closed

Starting node from a snapshot fails if the node has no blocks #1228

RalfWeinand opened this issue Jun 3, 2023 · 1 comment · Fixed by #1285, #1298, #1299 or #1304
Assignees
@heifner
Labels
bug Something isn't working 👍 lgtm OCI Work exclusive to OCI team
Milestone
Leap 4.0.2

Comments

@RalfWeinand
Copy link

We just noticed an issue with Leap v4.0.1 when we created a new Telos Testnet BP node. Starting it from a snapshot (without any blocks in the blocks folder) resulted in this error.

telegram-cloud-photo-size-5-6329874667602556377-y

We tried different snapshots, and different config.ini settings & start parameters (e.g. --delete-all-blocks) but nothing helped.

We then downgraded to Leap v3.2.3 and nodeos started from the same snapshot without blocks without this error.
@BenjaminGormanPMP BenjaminGormanPMP added this to the Leap 4.0.2 milestone Jun 8, 2023
@greg7mdp greg7mdp self-assigned this Jun 12, 2023
@heifner heifner added the bug Something isn't working label Jun 13, 2023
@greg7mdp
Copy link
Contributor

@RalfWeinand can you share the command and config.ini that you use to start nodeos?

@heifner heifner assigned heifner and unassigned greg7mdp Jun 13, 2023
@heifner heifner added the OCI Work exclusive to OCI team label Jun 13, 2023
@heifner heifner moved this from Todo to In Progress in Team Backlog Jun 13, 2023
heifner added a commit that referenced this issue Jun 14, 2023
@heifner
GH-1228 Add test for reading a snapshot with no block log option.
40332ec
heifner added a commit that referenced this issue Jun 14, 2023
@heifner
GH-1228 Better assertion message
02dd569
heifner added a commit that referenced this issue Jun 14, 2023
@heifner
GH-1228 Fix empty block log to support loading from a snapshot
4734d36
@heifner heifner mentioned this issue Jun 14, 2023
Merged
@heifner heifner linked a pull request Jun 14, 2023 that will close this issue
[4.0] Fix for loading snapshot with empty block log #1285
Merged
heifner added a commit that referenced this issue Jun 14, 2023
@heifner
GH-1228 Improve assert message
3406b68
heifner added a commit that referenced this issue Jun 14, 2023
@heifner
Merge pull request #1285 from AntelopeIO/GH-1228-empty-block-log-4.0
b9c2e73 
[4.0] Fix for loading snapshot with empty block log
heifner added a commit that referenced this issue Jun 14, 2023
@heifner
Merge remote-tracking branch 'origin/release/4.0' into GH-1228-empty-…
53d4847 
…block-log-main
@heifner heifner mentioned this issue Jun 14, 2023
Merged
heifner added a commit that referenced this issue Jun 14, 2023
@heifner
GH-1228 Additional tests for empty block log
2a3c0c3
heifner added a commit that referenced this issue Jun 14, 2023
@heifner
GH-1228 Fix for reading a snapshot without a block log but with a for…
9599669 
…k database
@heifner heifner mentioned this issue Jun 14, 2023
Merged
@heifner heifner linked a pull request Jun 14, 2023 that will close this issue
[4.0] Fix for loading a snapshot with an empty block log but an existing fork database #1299
Merged
heifner added a commit that referenced this issue Jun 14, 2023
@heifner
Merge pull request #1298 from AntelopeIO/GH-1228-empty-block-log-main
804d3a4 
[4.0 -> main] Fix for loading snapshot with empty block log
@github-project-automation github-project-automation bot moved this from In Progress to Done in Team Backlog Jun 14, 2023
heifner added a commit that referenced this issue Jun 14, 2023
@heifner
GH-1228 Include invalid get_blocks_result_v0 in the streamer output f…
3f19608 
…or debugging
heifner added a commit that referenced this issue Jun 15, 2023
@heifner
GH-1228 Log snapshot loaded for both cases
1dca359
heifner added a commit that referenced this issue Jun 15, 2023
@heifner
GH-1228 Increase the block_range to include fork
79535c6
heifner added a commit that referenced this issue Jun 15, 2023
@heifner
GH-1228 Correctly handle forks
308a985
heifner added a commit that referenced this issue Jun 15, 2023
@heifner
Merge pull request #1299 from AntelopeIO/GH-1228-empty-block-log-4.0
ce6f2cf 
[4.0] Fix for loading a snapshot with an empty block log but an existing fork database
heifner added a commit that referenced this issue Jun 15, 2023
@heifner
Merge remote-tracking branch 'origin/release/4.0' into GH-1228-empty-…
baccb32 
…blocklog-main
@heifner heifner mentioned this issue Jun 15, 2023
Merged
@heifner heifner linked a pull request Jun 15, 2023 that will close this issue
[4.0 -> main] Fix for loading a snapshot with an empty block log but an existing fork database #1304
Merged
heifner added a commit that referenced this issue Jun 15, 2023
@heifner
Merge pull request #1304 from AntelopeIO/GH-1228-empty-blocklog-main
6a44686 
[4.0 -> main] Fix for loading a snapshot with an empty block log but an existing fork database
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@heifner heifner

Labels
bug Something isn't working 👍 lgtm OCI Work exclusive to OCI team
Projects
Team Backlog
Archived in project
Milestone
Leap 4.0.2
5 participants
@RalfWeinand @greg7mdp @heifner @enf-ci-bot @BenjaminGormanPMP