[4.0] Fix for loading a snapshot with an empty block log but an existing fork database #1299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linh2931
reviewed
Jun 14, 2023
| try { | ||
| snapshot->validate(); | ||
| if( auto blog_head = blog.head() ) { | ||
| ilog( "Starting initialization from snapshot and block log ${b}-${e}, this may take a significant amount of time", | ||
| ("b", blog.first_block_num())("e", blog_head->block_num()) ); | ||
| read_from_snapshot( snapshot, blog.first_block_num(), blog_head->block_num() ); |
There was a problem hiding this comment.
Do you want to add a similar log saying snapshot has been loaded?
ilog( "Snapshot loaded, lib: ${lib}", ("lib", lib_num) );
linh2931
approved these changes
Jun 15, 2023
greg7mdp
reviewed
Jun 15, 2023
greg7mdp
approved these changes
Jun 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional test cases and fix for loading a snapshot without a block log. When loading a snapshot with a block log, the block log and fork database can be replayed if they start at or before the snapshot. If no block log exists, for example running with
--block-log-retain-blocks 0, then the fork database can't be consider valid.Includes a fix for new test introduced in #1276 which failed during ci/cd.
ship_streamer.cppupdated to correctly handle forks.Corner case related to #1228