Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change on main's abi_def(?) causing native contract unit tests for system contracts to fail compile #741

Closed
spoonincode opened this issue Feb 23, 2023 · 1 comment · Fixed by #742
Assignees
Labels
actionable bug Something isn't working 👍 lgtm OCI Work exclusive to OCI team

Comments

@spoonincode
Copy link
Member

On main, there is some change in abi_def (or something closely related I didn't track it down) that is causing system contracts' native contract unit tests to fail to compile. See
https://github.com/eosnetworkfoundation/eos-system-contracts/actions/runs/4248437173 for example. Also encountered it on EVM contract. I wouldn't be surprised if many native contract unit tests out in the wild would be ensnared by this.

Depending on the difficulty of getting this abi_def difference resolved, we could also just say it requires everyone downstream to update their test code. If that's the case, need to create issues in eos-system-contracts & reference-contracts.

@heifner
Copy link
Member

heifner commented Feb 23, 2023

This was caused by: #696 Specifically the change 62903c0
In the past when we changed abi_serializer we deprecated the methods when we realized it caused this kind of issue. Those methods are still there and deprecated actually. We could do the same thing for set_abi and a constructor that takes by const& instead of by rvalue reference.

@heifner heifner added bug Something isn't working actionable and removed triage labels Feb 23, 2023
@heifner heifner self-assigned this Feb 23, 2023
@heifner heifner added the OCI Work exclusive to OCI team label Feb 23, 2023
@heifner heifner moved this from Todo to In Progress in Team Backlog Feb 23, 2023
heifner added a commit that referenced this issue Feb 23, 2023
…rvalue reference to value so backward compatible for those using abi_serializer via tester.
heifner added a commit that referenced this issue Feb 23, 2023
Revert interface change of abi_serializer for tester
@github-project-automation github-project-automation bot moved this from In Progress to Done in Team Backlog Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actionable bug Something isn't working 👍 lgtm OCI Work exclusive to OCI team
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants