Revert interface change of abi_serializer for tester #742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rvalue reference to value so backward compatible for those using abi_serializer via tester.
|
|
greg7mdp
requested changes
Feb 23, 2023
greg7mdp
approved these changes
Feb 23, 2023
greg7mdp
approved these changes
Feb 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent change to
abi_serializer#696 Specifically the change 62903c0 caused existing test cases that use contract tester to not compile.This PR reverts the changes to
abi_serializerdeprecated methods and changesabi_serializerconstructor andset_abito takeabi_defby value instead of rvalue reference. This should allow existing users of contract tester to not have to update their test code.Resolves #741