Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move abi serialization of transaction trace off main thread for chain_plugin: get_table_rows #743

Closed
stephenpdeos opened this issue Feb 23, 2023 · 0 comments · Fixed by #1054
Closed

Move abi serialization of transaction trace off main thread for chain_plugin: get_table_rows #743

stephenpdeos opened this issue Feb 23, 2023 · 0 comments · Fixed by #1054
Assignees
@greg7mdp
Labels
actionable enhancement New feature or request 👍 lgtm
Milestone
Leap v5.0.0-rc1

Comments

@stephenpdeos
Copy link
Member

Similar to #696, transaction trace conversion to exploded fc::variant via abi_serializer can be mostly moved off the main thread. Although, the performance impact will not be as great as #696, it is likely still worth doing.

  • chain_plugin: get_table_rows and similar - this is harder because of the way deadline is handled - unless we relax deadline or some other heuristic for how long to grab rows vs converting those rows to expanded fc::variant
@stephenpdeos stephenpdeos converted this from a draft issue Feb 23, 2023
@greg7mdp greg7mdp mentioned this issue Mar 2, 2023
Closed
@BenjaminGormanPMP BenjaminGormanPMP moved this from Todo to In Progress in Team Backlog Apr 12, 2023
@stephenpdeos stephenpdeos added this to the Leap v5.0.0-rc1 milestone Apr 12, 2023
@greg7mdp greg7mdp mentioned this issue Apr 19, 2023
Merged
@greg7mdp greg7mdp moved this from In Progress to Awaiting Review in Team Backlog Apr 19, 2023
greg7mdp added a commit that referenced this issue Apr 19, 2023
@greg7mdp
Merge branch 'main' of github.com:AntelopeIO/leap into gh-743
1d19a7d
greg7mdp added a commit that referenced this issue Apr 21, 2023
@greg7mdp
Merge pull request #1054 from AntelopeIO/gh-743
48b6a4e 
Move abi serialization of transaction trace off main thread for `chain_plugin: get_table_rows` and `get_account`
@github-project-automation github-project-automation bot moved this from Awaiting Review to Done in Team Backlog Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@greg7mdp greg7mdp

Labels
actionable enhancement New feature or request 👍 lgtm
Projects
Team Backlog
Archived in project
Milestone
Leap v5.0.0-rc1
2 participants
@greg7mdp @stephenpdeos