Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move abi serialization of transaction trace off main thread #698

Closed
heifner opened this issue Feb 7, 2023 · 1 comment · Fixed by #999
Closed

Move abi serialization of transaction trace off main thread #698

heifner opened this issue Feb 7, 2023 · 1 comment · Fixed by #999
Assignees
@greg7mdp
Labels
discussion enhancement New feature or request 👍 lgtm
Milestone
Leap v5.0.0-rc1

Comments

@heifner
Copy link
Member

heifner commented Feb 7, 2023 •
edited by greg7mdp
Loading

Similar to #696, transaction trace conversion to exploded fc::variant via abi_serializer can be mostly moved off the main thread. Although, the performance impact will not be as great as #696, it is likely still worth doing.

  • chain_plugin: send_transaction, send_transaction2, compute_transaction
  • chain_plugin: get_scheduled_transactions (since this is deprecated, maybe not worth it)
  • trx_retry_db: to_variant_with_abi => see trx_retry_db.cpp : on_applied_transaction)
  • trace_api_plugin: serialize_to_variant => already off main thread, moved to issue trace_api_plugin: optimizations #988 for further optimizations
@heifner heifner added enhancement New feature or request discussion and removed triage labels Feb 7, 2023
@greg7mdp
Copy link
Contributor

greg7mdp commented Mar 2, 2023 •
edited
Loading

As Bucky suggested, try to share code for moving code off the main thread (see PRs 758, 696 and issue 743)

@greg7mdp greg7mdp self-assigned this Mar 19, 2023
@greg7mdp greg7mdp moved this from Todo to In Progress in Team Backlog Mar 22, 2023
@greg7mdp greg7mdp mentioned this issue Apr 5, 2023
Merged
greg7mdp added a commit that referenced this issue Apr 6, 2023
@greg7mdp
Merge branch 'gh-698' of github.com:AntelopeIO/leap into gh-698
71824ff
greg7mdp added a commit that referenced this issue Apr 6, 2023
@greg7mdp
Merge branch 'main' of github.com:AntelopeIO/leap into gh-698
43f64b3
greg7mdp added a commit that referenced this issue Apr 7, 2023
@greg7mdp
Merge pull request #973 from AntelopeIO/gh-698
f31e527 
Unify definitions of `next_function` and its variant parameter
greg7mdp added a commit that referenced this issue Apr 10, 2023
@greg7mdp
Merge branch 'gh-698' of github.com:AntelopeIO/leap into gh-698-part2
0b3cc3d
greg7mdp added a commit that referenced this issue Apr 10, 2023
@greg7mdp
Merge branch 'gh-698' of github.com:AntelopeIO/leap into gh-698-part2
e616649
greg7mdp added a commit that referenced this issue Apr 10, 2023
@greg7mdp
Merge branch 'main' of github.com:AntelopeIO/leap into gh-698-part2
01a0dc5
@greg7mdp greg7mdp mentioned this issue Apr 11, 2023
Merged
@greg7mdp greg7mdp moved this from In Progress to Awaiting Review in Team Backlog Apr 11, 2023
greg7mdp added a commit that referenced this issue Apr 12, 2023
@greg7mdp
Merge branch 'main' of github.com:AntelopeIO/leap into gh-698-part2
6457040
@stephenpdeos stephenpdeos added this to the Leap v5.0.0-rc1 milestone Apr 12, 2023
greg7mdp added a commit that referenced this issue Apr 13, 2023
@greg7mdp
Merge pull request #999 from AntelopeIO/gh-698-part2
3b2f665 
Move abi serialization of transaction trace off main thread
@github-project-automation github-project-automation bot moved this from Awaiting Review to Done in Team Backlog Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@greg7mdp greg7mdp

Labels
discussion enhancement New feature or request 👍 lgtm
Projects
Team Backlog
Archived in project
Milestone
Leap v5.0.0-rc1
Development

Successfully merging a pull request may close this issue.

Move abi serialization of transaction trace off main thread AntelopeIO/leap
4 participants
@greg7mdp @heifner @stephenpdeos @enf-ci-bot