Move abi serialization of transaction trace off main thread #999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heifner
requested changes
Apr 11, 2023
plugins/chain_plugin/include/eosio/chain_plugin/chain_plugin.hpp
Outdated
Show resolved
Hide resolved
linh2931
reviewed
Apr 12, 2023
heifner
reviewed
Apr 12, 2023
heifner
requested changes
Apr 12, 2023
plugins/chain_plugin/include/eosio/chain_plugin/chain_plugin.hpp
Outdated
Show resolved
Hide resolved
heifner
approved these changes
Apr 13, 2023
linh2931
approved these changes
Apr 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #698.
Similar to #696, move transaction trace conversion to exploded fc::variant via abi_serializer off the main thread.
Although, the performance impact will not be as great as #696, it is likely still worth doing.
chain_plugin APIs updated:
get_blockto use common architecturesend_transactionabove to use one common implementation.I will have a further PR optimizing the conversion to fc::variant by avoiding unnecessary copies of abi_serializer (changes will be in abi_serializer.hpp).