Unify definitions of next_function and its variant parameter
#973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
between main thread and http thread pool
So that it is defined in a single location (DRY) and can be easily updated.
heifner
requested changes
Apr 5, 2023
heifner
approved these changes
Apr 6, 2023
linh2931
reviewed
Apr 7, 2023
plugins/chain_plugin/include/eosio/chain_plugin/trx_retry_db.hpp
Outdated
Show resolved
Hide resolved
linh2931
approved these changes
Apr 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in preparation for the changes for issue #698.
I have figured out a way to implement issue #698 with minimal code changes, but it requires changing a function type (and its variant parameter) that is used throughout our code.
Because these types are defined in many locations, I wanted to have a first PR with no functional changes, just to make sure that the type is defined in a single location in our code. The benefit is that it should be easy to see that this PR, even though it has many changes, does not change any behavior.