[4.0] Correctly handle close while syncing #1171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heifner
commented
May 13, 2023
| } | ||
| return; | ||
| } | ||
|
|
There was a problem hiding this comment.
Note this was already removed on main as an optimization. See #1045.
linh2931
reviewed
May 13, 2023
plugins/net_plugin/net_plugin.cpp
Outdated
| @@ -1591,7 +1591,7 @@ namespace eosio { | |||
| sync_known_lib_num = highest_lib_num; | |||
|
|
|||
| // if closing the connection we are currently syncing from, then reset our last requested and next expected. | |||
linh2931
approved these changes
May 14, 2023
vladtr
approved these changes
May 15, 2023
This was referenced Jun 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When generating snapshots during syncing, nodeos would timeout a sync and close the connection. The close would cause all queued blocks on that connection to be dropped. Also the
sync_next_expected_numwould not be reset because thesync_sourcehad been reset.Resolves #1170