Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0 -> main] P2P excessive logging caused by message spamming #1271

Merged
merged 6 commits into from
Jun 12, 2023

Conversation

heifner
Copy link
Member

@heifner heifner commented Jun 12, 2023

Two main issues resolved by this PR in 4.0.

  • "Infinite" loop of notice_message <-> handshake_message when clock skew. The clock skew caused peer to keep trying to inform other that it has the blocks already.
  • Handshakes were being sent to every peer anytime any peer connection was closed. This was introduced in 4.0.1 by [4.0] Correctly handle close while syncing #1171. This PR handles this case better by resetting sync_next_expected_num on rejected block instead of spamming all connections with handshakes.

These issues were already fixed in main by work on #1072. (hence the zero diff)

Additional fixes in this 4.0 PR backported from #1072 work:

  • Includes fix for using nanoseconds resolution for time_message.
  • Update known head block on catch_up notice_message. The information is provided might as well use it instead of waiting for a handshake_message.

Merges release/4.0 into main including #1267.

Resolves #1240

@heifner heifner requested review from linh2931 and vladtr June 12, 2023 19:06
@heifner heifner added the OCI Work exclusive to OCI team label Jun 12, 2023
@heifner heifner merged commit d86ba3a into main Jun 12, 2023
@heifner heifner deleted the GH-1240-net-loop-main branch June 12, 2023 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCI Work exclusive to OCI team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Excessive info logs generated by Nodeos causing rapid increase in syslog size
3 participants