[4.0 -> main] P2P excessive logging caused by message spamming #1271
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two main issues resolved by this PR in 4.0.
notice_message
<->handshake_message
when clock skew. The clock skew caused peer to keep trying to inform other that it has the blocks already.sync_next_expected_num
on rejected block instead of spamming all connections with handshakes.These issues were already fixed in
main
by work on #1072. (hence the zero diff)Additional fixes in this 4.0 PR backported from #1072 work:
nanoseconds
resolution fortime_message
.catch_up
notice_message
. The information is provided might as well use it instead of waiting for ahandshake_message
.Merges
release/4.0
intomain
including #1267.Resolves #1240