Reduce the number of thread hops for read-only trxs #1702
Conversation
| // not thread safe, but as long as set_main_thread_id() only called at program startup from main thread before | ||
| // other threads are created then this will be safe to access. | ||
| std::thread::id get_main_thread_id() const { | ||
| assert(main_thread_id_ != std::thread::id()); |
There was a problem hiding this comment.
Why not initialize this in the member, so it is initialized when the executor is constructed?
std::thread::id main_thread_id_ { std::thread::id()) };
There was a problem hiding this comment.
I was not thinking it would always be created on the main thread. But in practice I guess it would be.
There was a problem hiding this comment.
Actually the tests create it on a diff thread. I can re-work those tests.
There was a problem hiding this comment.
I assumed the Application was always created on the main thread, but if that's not the case you can ignore my comment.
There was a problem hiding this comment.
In the nomial use-case it is, it just isn't for our tests, but I should be able to fix the tests.
| @@ -164,8 +164,8 @@ inline auto make_http_response_handler(http_plugin_state& plugin_state, detail:: | |||
| plugin_state.bytes_in_flight += payload_size; | |||
|
|
|||
| // post back to an HTTP thread to allow the response handler to be called from any thread | |||
| boost::asio::post(plugin_state.thread_pool.get_executor(), | |||
| [&plugin_state, session_ptr, code, payload_size, response = std::move(response), content_type]() { | |||
| boost::asio::dispatch(plugin_state.thread_pool.get_executor(), | |||
There was a problem hiding this comment.
I'm having a hard time figuring out why dispatch is appropriate here? Why can't we just execute the lambda here?
There was a problem hiding this comment.
dispatch is the one that allows execution of the lambda here. post is the one that make sure it always executes outside this thread.
There was a problem hiding this comment.
Do we really need to call dispatch instead of just executing the lambda's code here?
There was a problem hiding this comment.
This can be called from the application thread, in that case we want to do the json parsing on the http thread.
… so that application is created on the main thread.
Optimize read-only trx execution by reducing the number of thread hops for execution.
This branch: https://github.com/AntelopeIO/leap/actions/runs/6365190135 16501 TPS
Compared with GH-1662-close: https://github.com/AntelopeIO/leap/actions/runs/6356928532 15001 TPS