[5.0] Test: read-only trxs should only be posted to read_exclusive queue #1766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of #1702 read only trxs should only be posted to
read_exclusivequeue. Thetest_read_only_trxtest was posting them to theread_onlyqueue which caused them to sometimes run during the write window. They were run in the write window because read only transactions are allowed to run on the main thread. It is not clear if this is why test failed but seems we can assume that is the problem unless it fails again. I ran thetest_read_only_trxmany times locally without failure with this fix.Resolves #1736