Instrument producer_plugin for Prometheus #537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spoonincode
reviewed
Dec 5, 2022
| @@ -154,6 +154,7 @@ class chain_plugin_impl { | |||
| fc::microseconds abi_serializer_max_time_us; | |||
| std::optional<bfs::path> snapshot_path; | |||
|
|
|||
| std::shared_ptr<chain_plugin_metrics> chain_metrics; | |||
There was a problem hiding this comment.
What necessitates this being a shared_ptr over a unique_ptr, or even just returning a reference to a const chain_plugin_metrics&?
heifner
requested changes
Dec 7, 2022
plugins/chain_interface/include/eosio/chain/plugin_interface.hpp
Outdated
Show resolved
Hide resolved
| struct runtime_metric { | ||
| metric_type type; | ||
| const std::string family; | ||
| const std::string label; | ||
| std::atomic<int64_t> value; |
plugins/producer_plugin/include/eosio/producer_plugin/producer_plugin.hpp
Outdated
Show resolved
Hide resolved
plugins/prometheus_plugin/include/eosio/prometheus_plugin/prometheus_plugin.hpp
Outdated
Show resolved
Hide resolved
heifner
reviewed
Dec 13, 2022
heifner
reviewed
Dec 13, 2022
heifner
reviewed
Dec 13, 2022
heifner
reviewed
Dec 15, 2022
heifner
approved these changes
Dec 16, 2022
|
|
||
| for (auto& rtm : _counters) { | ||
| auto new_val = static_cast<double>(std::get<2>(rtm).value); | ||
| std::get<1>(rtm).Increment(new_val-std::get<1>(rtm).Value()); |
There was a problem hiding this comment.
Did you decide this was not needed?
| @@ -832,6 +832,10 @@ class read_write { | |||
|
|
|||
| } // namespace chain_apis | |||
|
|
|||
| struct chain_plugin_metrics { | |||
| //runtime_metric | |||
There was a problem hiding this comment.
I assume this will be cleaned up with the chain_plugin PR to the feature branch.
There was a problem hiding this comment.
yes, changes for that are coming in the instrument chain plugin pr
cmadh
pushed a commit
to cmadh/leap
that referenced
this pull request
Jan 2, 2023
…l-logging [3.2] Additional transaction/block time logging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a base set of metrics for to publish to Prometheus to the producer_plugin.