Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle shutdown of http_plugin lifetime #540

Merged
merged 1 commit into from
Dec 9, 2022
Merged

Handle shutdown of http_plugin lifetime #540

merged 1 commit into from
Dec 9, 2022

Conversation

heifner
Copy link
Member

@heifner heifner commented Dec 6, 2022

Cleaner handling of shutdown in http_plugin.
Inspired by @spoonincode comment: #537 (comment)

@heifner heifner requested a review from spoonincode December 6, 2022 14:26
Copy link
Member

@spoonincode spoonincode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this is an okay crutch for now, but I really think we should explore a two stage shutdown or some other solution to remove these dangers.

@heifner heifner merged commit e8d9e27 into main Dec 9, 2022
@heifner heifner deleted the http-shutdown branch December 9, 2022 12:17
@heifner heifner added the OCI Work exclusive to OCI team label Dec 9, 2022
cmadh pushed a commit to cmadh/leap that referenced this pull request Jan 2, 2023
…OGH-540-sig-provider

[3.2] Separate out signature provider from producer plugin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCI Work exclusive to OCI team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants