[4.0] Restore read-mode=speculative #986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heifner
commented
Apr 6, 2023
| if ( read_mode == db_read_mode::HEAD ) { | ||
| EOS_ASSERT( head->block, block_validate_exception, "attempting to pop a block that was sparsely loaded from a snapshot"); | ||
| } | ||
| EOS_ASSERT( head->block, block_validate_exception, "attempting to pop a block that was sparsely loaded from a snapshot"); |
There was a problem hiding this comment.
Seems like this should always be asserted even for IRREVERSIBLE mode.
…ead-mode=speculative
linh2931
reviewed
Apr 7, 2023
| @@ -120,11 +120,17 @@ Config Options for eosio::chain_plugin: | |||
| applied to them (may specify multiple | |||
| times) | |||
| --read-mode arg (=head) Database read mode ("head", | |||
| "irreversible"). | |||
| "speculative", "irreversible"). | |||
There was a problem hiding this comment.
As speculative is deprecated, place it after irreversible
| contains state changes by transactions | ||
| in the blockchain up to the head block | ||
| as well as some transactions not yet | ||
| included in the blockchain. |
There was a problem hiding this comment.
Can you specify if a transaction will be replayed, to be consistent with the other two's description?
| "In \"head\" mode: database contains state changes up to the head block; transactions received by the node are relayed if valid.\n" | ||
| "In \"speculative\" mode: (DEPRECATED: head mode recommended) database contains state changes by transactions in the blockchain up to the head block as well as some transactions not yet included in the blockchain.\n" |
linh2931
approved these changes
Apr 7, 2023
arhag
approved these changes
Apr 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restore deprecated
read-mode=speculativethat was removed in #414.read-mode=headremains the default.Although,
read-mode=speculativecan cause confusion to users, this PR restores the option as an alternative non-defaultread-mode. This does not restore persisted trxs. Persisted trxs were API trxs re-applied for each block. This new restoredspeculativemode therefore will not have the state of API trxs auto applied at the start of each speculative block. It is up to the user to re-apply any transactions at each speculative block in order to observe their side-effects.Also the restored
read-mode=speculativedoes not, unlike the old removedread-mode=speculative, apply schedule changes, protocol activations, oronblocktrxs for a speculative mode into the speculative block which will be aborted when a new block is received from the network. This is in alignment withread-mode=head.Resolves #980