[4.0 -> main] Restore read-mode=speculative #992
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restore deprecated
read-mode=speculative
that was removed in #414.read-mode=head
remains the default.Although,
read-mode=speculative
can cause confusion to users, this PR restores the option as an alternative non-defaultread-mode
. This does not restore persisted trxs. Persisted trxs were API trxs re-applied for each block. This new restoredspeculative
mode therefore will not have the state of API trxs auto applied at the start of each speculative block. It is up to the user to re-apply any transactions at each speculative block in order to observe their side-effects.Also the restored
read-mode=speculative
does not, unlike the old removedread-mode=speculative
, apply schedule changes, protocol activations, oronblock
trxs for a speculative mode into the speculative block which will be aborted when a new block is received from the network. This is in alignment withread-mode=head
.Merges #986 into
main
Resolves #980