[1.0.4 -> main] Fix fetch block with no block log #1060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er and fetch_block_by_id
… with no block log
…_log-1.0 [1.0.4] Fix fetch block with no block log
…block_no_block_log-main
linh2931
reviewed
Dec 10, 2024
|
|
||
| if (!_is_savanna_active && irreversible_mode() && chain_plug->accept_transactions()) { | ||
| wlog("Legacy consensus active. Accepting speculative transaction execution not recommended in read-mode=irreversible"); | ||
| } |
There was a problem hiding this comment.
I guess it is OK this is not in rel 1.0.
linh2931
approved these changes
Dec 10, 2024
greg7mdp
approved these changes
Dec 10, 2024
|
Note:start |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The startup of
producer_pluginusesfetch_block_by_numberto primeon_irreversible_blockwith LIB.spring/plugins/producer_plugin/producer_plugin.cpp
Lines 1612 to 1613 in 838e885
When running without a block log,
fetch_block_by_numberalways returnednullptrfor LIB.Update
fetch_block_by_numberandfetch_block_by_idto find LIB in fork database.Merges
release/1.0intomainincluding #1059. Adds commit 5c8ea40.Resolves #1052