Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.0.4 -> main] Fix fetch block with no block log #1060

Merged
merged 6 commits into from
Dec 11, 2024
Merged

[1.0.4 -> main] Fix fetch block with no block log #1060

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c0c83aa
GH-1052 Add tests that verify LIB can be found by fetch_block_by_numb…
heifner Dec 6, 2024
838e885
GH-1052 Fix fetch_block_by_number and fetch_block_by_id to return LIB…
heifner Dec 6, 2024
ee1c477
GH-1052 Verify root exists before accessing id()
heifner Dec 6, 2024
fbe8949
Merge pull request #1059 from AntelopeIO/GH-1052-fetch_block_no_block…
heifner Dec 10, 2024
60efe98
Merge remote-tracking branch 'spring/release/1.0' into GH-1052-fetch_…
heifner Dec 10, 2024
5c8ea40
GH-1052 Only warn if is_savanna_active is set.
heifner Dec 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions plugins/producer_plugin/producer_plugin.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1609,14 +1609,14 @@ void producer_plugin_impl::plugin_startup() {
const auto fork_db_root = chain.fetch_block_by_number(fork_db_root_num);
if (fork_db_root) {
on_irreversible_block(fork_db_root);

if (!_is_savanna_active && irreversible_mode() && chain_plug->accept_transactions()) {
wlog("Legacy consensus active. Accepting speculative transaction execution not recommended in read-mode=irreversible");
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it is OK this is not in rel 1.0.

} else {
_irreversible_block_time = fc::time_point::maximum();
}

if (!_is_savanna_active && irreversible_mode() && chain_plug->accept_transactions()) {
wlog("Legacy consensus active. Accepting speculative transaction execution not recommended in read-mode=irreversible");
}

if (is_configured_producer()) {
ilog("Launching block production for ${n} producers at ${time}.", ("n", _producers.size())("time", fc::time_point::now()));

Expand Down
Loading