Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IF: Do not use watermarks for savanna #55

Merged
merged 1 commit into from
Apr 19, 2024
Merged

Conversation

heifner
Copy link
Member

@heifner heifner commented Apr 19, 2024

Watermarks and not needed or desired for Savanna.

Resolves #9

@heifner heifner added the OCI Work exclusive to OCI team label Apr 19, 2024
@heifner heifner requested review from linh2931 and greg7mdp April 19, 2024 13:38
@heifner heifner linked an issue Apr 19, 2024 that may be closed by this pull request
if (watermark_bn < head_block_num) {
blocks_to_confirm = (uint16_t)(std::min<uint32_t>(std::numeric_limits<uint16_t>::max(), (head_block_num - watermark_bn)));
uint16_t blocks_to_confirm = 0;
if (in_producing_mode()) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems more efficient to not grab the head_block_state_legacy() unless producing which is when it is needed.

Copy link
Contributor

@greg7mdp greg7mdp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weird diff, the pre doesn't match what I see locally in the savanna branch.

@heifner heifner merged commit 08a7157 into savanna Apr 19, 2024
36 checks passed
@heifner heifner deleted the GH-9-avoid-watermark branch April 19, 2024 15:32
@ericpassmore
Copy link
Contributor

Note:start
group: IF
category: INTERNALS
summary: Do not use watermarks for Savanna. They are not needed or desired.
Note:end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCI Work exclusive to OCI team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid watermark checks for Proper IF Blocks
4 participants