-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hedging strategy also deep-copies context for primary execution #1754
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any impact to benchmarks (+ve or -ve) from this change?
I don't think so, but let me re-run just in case. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1754 +/- ##
==========================================
- Coverage 84.56% 84.52% -0.05%
==========================================
Files 307 306 -1
Lines 6790 6772 -18
Branches 1043 1042 -1
==========================================
- Hits 5742 5724 -18
Misses 839 839
Partials 209 209
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
bench/BenchmarkDotNet.Artifacts/results/Polly.Core.Benchmarks.HedgingBenchmark-report-github.md
Show resolved
Hide resolved
@martintmk Would you consider this change to be a patch or a minor change? If we take the change for AoT too, then can that be 8.0.1 or does this change make it 8.1.0? I'm thinking 8.0.1, but if you consider this minor rather than patch then we can do an 8.1.0 and the .NET 8 release will become 8.2.0. |
We had some API additions in #1687 so I would say we should do 8.1.0. |
Pull Request
The issue or feature being addressed
#1727
Details on the issue fix or feature implementation
As per #1727 there was inconsistency on how the hedging contexts for primary executions are handled. Instead of creating deep-clone, the hedging strategy re-used the original context.
With this change, the handling is the same for both primary and hedged actions. Hedging strategy always creates a deep clone in all scenarios.
This also simplifies the implementation and handling of contexts.
Confirm the following