Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#27 Add effect handler for no effect #262

Merged
merged 1 commit into from
May 15, 2022

Conversation

vincent4vx
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented May 15, 2022

Codecov Report

Merging #262 (db488d2) into master (2cc3a0b) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #262      +/-   ##
============================================
- Coverage     95.80%   95.80%   -0.01%     
- Complexity     7989     7992       +3     
============================================
  Files          1286     1287       +1     
  Lines         20429    20433       +4     
  Branches       1168     1168              
============================================
+ Hits          19573    19575       +2     
- Misses          665      667       +2     
  Partials        191      191              
Impacted Files Coverage Δ
.../castable/effect/handler/misc/NoEffectHandler.java 100.00% <100.00%> (ø)
...raknemu/game/fight/module/CommonEffectsModule.java 100.00% <100.00%> (ø)
...vieux/araknemu/core/dbal/SimpleConnectionPool.java 85.71% <0.00%> (-5.72%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2cc3a0b...db488d2. Read the comment docs.

@vincent4vx vincent4vx merged commit d8c2ab0 into Arakne:master May 15, 2022
@vincent4vx vincent4vx deleted the spell-effect-no-effect branch May 15, 2022 12:25
ArleeDev pushed a commit to ArleeDev/Araknemu that referenced this pull request Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant