feat(fight): Add trap effect (#27) #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vendethiel
reviewed
May 30, 2023
| @@ -72,11 +77,12 @@ public final Castable action() { | |||
| } | |||
|
|
|||
| @Override | |||
| public final Optional<Spell> spell() { | |||
| @Pure | |||
| public final @Nullable Spell spell() { | |||
There was a problem hiding this comment.
Je ne suis pas fan de l'API optional, et checkerframework apporte une bonne sécurité compile time, ce que je préfère. Mais bon l'idéal reste une vraie gestion native un peu comme en Kotlin, même si ça n'arrivera jamais en java 😢
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #287 +/- ##
==========================================
Coverage 96.08% 96.09%
- Complexity 8337 8414 +77
==========================================
Files 1322 1329 +7
Lines 21159 21413 +254
Branches 1265 1286 +21
==========================================
+ Hits 20330 20576 +246
- Misses 635 640 +5
- Partials 194 197 +3
☔ View full report in Codecov by Sentry. |
ArleeDev
pushed a commit
to ArleeDev/Araknemu
that referenced
this pull request
Mar 7, 2024
feat(fight): Add trap effect (Arakne#27)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.