Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fight): Handle boost effects without duration #27 #298

Conversation

vincent4vx
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Jul 22, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01 🎉

Comparison is base (2526bab) 96.20% compared to head (3d6800b) 96.21%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #298      +/-   ##
============================================
+ Coverage     96.20%   96.21%   +0.01%     
- Complexity     8619     8622       +3     
============================================
  Files          1357     1357              
  Lines         21871    21881      +10     
  Branches       1315     1315              
============================================
+ Hits          21040    21052      +12     
+ Misses          640      638       -2     
  Partials        191      191              
Impacted Files Coverage Δ
...araknemu/game/fight/castable/effect/buff/Buff.java 100.00% <ø> (ø)
...nemu/game/fight/castable/effect/buff/BuffList.java 100.00% <100.00%> (ø)
...acteristic/AbstractAlterCharacteristicHandler.java 100.00% <100.00%> (ø)
...ect/handler/misc/ApplySpellOnStartTurnHandler.java 100.00% <100.00%> (ø)
.../castable/effect/handler/misc/SkipTurnHandler.java 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vincent4vx vincent4vx merged commit 8467ba5 into Arakne:master Jul 22, 2023
8 checks passed
@vincent4vx vincent4vx deleted the feature-handle-zero-duration-boost-effects branch July 22, 2023 17:18
ArleeDev pushed a commit to ArleeDev/Araknemu that referenced this pull request Mar 7, 2024
…ation-boost-effects

feat(fight): Handle boost effects without duration Arakne#27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant