Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: update mobile search design #1018

Merged
merged 16 commits into from
Jan 13, 2022
Merged

refactor: update mobile search design #1018

merged 16 commits into from
Jan 13, 2022

Conversation

alexbarnsley
Copy link
Member

@alexbarnsley alexbarnsley commented Dec 9, 2021 •
edited
Loading

Summary

https://app.clickup.com/t/1npyzb6

Waiting on ArkEcosystem/laravel-foundation#171

Checklist

  • I checked my UI changes against the design and there are no notable differences
  • I checked my UI changes for any responsiveness issues
  • I checked my UI changes in light AND dark mode
  • I checked my (code) changes for obvious issues, debug statements and commented code
  • I opened a corresponding card on Clickup for any remaining TODOs in my code
  • I added a short description on how to test this PR (if necessary)
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@alexbarnsley alexbarnsley mentioned this pull request Dec 9, 2021
Merged
9 tasks
@github-actions github-actions bot added the refactor The pull request improves or enhances an existing implementation. label Dec 9, 2021
@alexbarnsley alexbarnsley marked this pull request as ready for review December 16, 2021 22:07
@ItsANameToo
Copy link
Member

search button is slightly smaller than the loading button

@ItsANameToo ItsANameToo marked this pull request as draft January 13, 2022 10:40
@alexbarnsley alexbarnsley marked this pull request as ready for review January 13, 2022 10:53
@ItsANameToo ItsANameToo merged commit fdbdc32 into develop Jan 13, 2022
@ItsANameToo ItsANameToo deleted the refactor/update-mobile-search-design branch January 13, 2022 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ItsANameToo ItsANameToo ItsANameToo approved these changes

@faustbrian faustbrian Awaiting requested review from faustbrian

@samharperpittam samharperpittam Awaiting requested review from samharperpittam samharperpittam is a code owner

Assignees
No one assigned
Labels
refactor The pull request improves or enhances an existing implementation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexbarnsley @ItsANameToo