-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add chevron open/close component #171
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
leMaur
suggested changes
Dec 10, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alexbarnsley Few adjustments, other than that I think it's good to have this sort of components 👍🏼
Co-authored-by: Maurizio <leMaur@users.noreply.github.com>
leMaur
approved these changes
Dec 13, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alexbarnsley 👍🏼 all good to me
ItsANameToo
approved these changes
Dec 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related to https://app.clickup.com/t/1npyzb6
Required by ArkEcosystem/explorer#1018
This is the icon that's used in a few places (e.g. navbar dropdown)
Note: the
transform
css class makes the chevron rotate counter-clockwise. By default it's clockwise. I kept these in place when updating to use the component. This could possibly be a property instead though if it is actually intended to reverse (reverse-rotation
) @ItsANameToo? 🤔Also contains a couple of tweaks to the mobile navbar children dropdown - it was hardcoded to output "Products" instead of whatever the menu item was called. I kept the change here as I noticed it when updating to use the chevron component
Checklist
icons.html
file and checked if my newly added icon is shown correctly (if necessary)