Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add chevron open/close component #171

Merged
merged 14 commits into from
Dec 13, 2021

Conversation

alexbarnsley
Copy link
Member

Summary

Related to https://app.clickup.com/t/1npyzb6

Required by ArkEcosystem/explorer#1018

This is the icon that's used in a few places (e.g. navbar dropdown)

Note: the transform css class makes the chevron rotate counter-clockwise. By default it's clockwise. I kept these in place when updating to use the component. This could possibly be a property instead though if it is actually intended to reverse (reverse-rotation) @ItsANameToo? 🤔

Also contains a couple of tweaks to the mobile navbar children dropdown - it was hardcoded to output "Products" instead of whatever the menu item was called. I kept the change here as I noticed it when updating to use the chevron component

Checklist

  • I checked my UI changes against the design and there are no notable differences
  • I checked my UI changes for any responsiveness issues
  • I checked my (code) changes for obvious issues, debug statements and commented code
  • I provided a screenshot of my changes to the component (if applicable)
  • I regenerated the icons.html file and checked if my newly added icon is shown correctly (if necessary)
  • I added an explanation on how to use the component to the readme (if necessary)
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

Copy link
Contributor

@leMaur leMaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexbarnsley Few adjustments, other than that I think it's good to have this sort of components 👍🏼

examples/ui.md Outdated Show resolved Hide resolved
examples/ui.md Outdated Show resolved Hide resolved
examples/ui.md Outdated Show resolved Hide resolved
@leMaur leMaur self-assigned this Dec 10, 2021
@ItsANameToo ItsANameToo marked this pull request as draft December 10, 2021 13:25
@alexbarnsley alexbarnsley marked this pull request as ready for review December 13, 2021 10:16
Copy link
Contributor

@leMaur leMaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexbarnsley 👍🏼 all good to me

@ItsANameToo ItsANameToo merged commit ae467f6 into main Dec 13, 2021
@ItsANameToo ItsANameToo deleted the feat/chevron-open-close-component branch December 13, 2021 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants