Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Russian translation #192

Merged
merged 78 commits into from
Dec 23, 2017
Merged

Added Russian translation #192

merged 78 commits into from
Dec 23, 2017

Conversation

unhappytroll
Copy link
Contributor

Added Russian translation to all keys in @AresModAchillesExpansion\addons\language_f\stringtable.xml.
Polished existed translation a little.

Added Russian translation to all keys in @AresModAchillesExpansion\addons\language_f\stringtable.xml.
Polished existed translation a little.
@CreepPork CreepPork self-assigned this Dec 5, 2017
@CreepPork CreepPork added change Issue or PR that will change a implemented feature. priority/medium Issue or PR that impacts some portions of the user base and should be resolved with due time. labels Dec 5, 2017
@CreepPork CreepPork added this to the 0.1.0 milestone Dec 5, 2017
CreepPork
CreepPork previously approved these changes Dec 5, 2017
Fixed localisation string for aborting fire mission message.
Maked different localisation strings for both modules.
Copy link
Member

@CreepPork CreepPork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not modify the AddonBuilder.bat inside your tracked Git directories.

Added warning do dialog
Added localization to dialod code.
- [Rollback] Removed changes in categories names due to selection logic;
- [Tweak] Reworked translation (too long strings)
- [New] Added some new containers for sorting sake
-[Tweak] Preliminary sorting of keys by containers;
- [New] Added new localisation keys for nonlocalized scripts
@unhappytroll
Copy link
Contributor Author

Forgot to remove bat and ini files again, sorry, won't do it again.

-[Fix] Fixed some errors in localization keys
<Russian>Неподвижные объекты</Russian>
<German>Statische Objekte</German>
</Key>
<Key ID="STR_AMAE_GAME_LOGIC">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is this used?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dunno. haven't seen in menu.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually, this is most probably from "Add/Remove objects" dialog window.

@@ -13,7 +13,8 @@ private _dialogResult =
[
localize "STR_AMAE_CHANGE_ALTITUDE",
[
[(localize "STR_AMAE_Altitude_ASL_ATL") + " [m]", "","0"]
[(localize "STR_AMAE_Altitude_ASL_ATL") + " [m]", "","0"];
[(localize "STR_AMAE_ALT_CHANGE_WARNING")];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brackets () are not needed and don't add it by itself.

@@ -13,7 +13,8 @@ private _dialogResult =
[
localize "STR_AMAE_CHANGE_ALTITUDE",
[
[(localize "STR_AMAE_Altitude_ASL_ATL") + " [m]", "","0"]
[(localize "STR_AMAE_Altitude_ASL_ATL") + " [m]", "","0"];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Semicolon at the end breaks it, it must be a comma or nothing (if anything below it doesn't exist)

Added localized strings.
Added warning message.
Localised dialog, fixed one string for uniformity
Added strings for newly localized dilogs
Russian translation polished further (shorted some long strings, which has trouble to fit into controls, dialogs and menu
@CreepPork CreepPork merged commit b9607b9 into ArmaAchilles:(0.1.0) Dec 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change Issue or PR that will change a implemented feature. priority/medium Issue or PR that impacts some portions of the user base and should be resolved with due time.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants