fix: Camera ignore turn flash off exception (openfoodfacts#2228)

* Only accepts barcodes on half-top of the image * Fix for "Unhandled Exception: CameraException(setFlashModeFailed, Could not set flash mode.)" * Also try/catch from pausePreview
AshAman999 · Jun 9, 2022 · 004f1aa · 004f1aa
1 parent e335b9a
commit 004f1aa
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 2 deletions.
diff --git a/packages/smooth_app/lib/pages/scan/camera_controller.dart b/packages/smooth_app/lib/pages/scan/camera_controller.dart
@@ -90,8 +90,18 @@ class SmoothCameraController extends CameraController {
     }
 
     if (_isInitialized) {
-      await _pauseFlash();
-      await super.pausePreview();
+      try {
+        await _pauseFlash();
+      } catch (exception) {
+        // Camera already disposed
+      }
+
+      try {
+        await super.pausePreview();
+      } catch (exception) {
+        // Camera already disposed
+      }
+
       _isPaused = true;
     }
   }

diff --git a/packages/smooth_app/lib/pages/scan/mkit_scan_helper.dart b/packages/smooth_app/lib/pages/scan/mkit_scan_helper.dart
@@ -227,12 +227,17 @@ class _MLKitScanDecoderIsolate {
 
     final CameraImage image = CameraImage.fromPlatformData(message);
     final InputImage cropImage = _cropImage(image);
+    final double imageHeight =
+        cropImage.inputImageData?.size.longestSide ?? double.infinity;
 
     final List<Barcode> barcodes =
         await _barcodeScanner.processImage(cropImage);
 
     port.send(
       barcodes
+          // Only accepts barcodes on half-top of the image
+          .where((Barcode barcode) =>
+              (barcode.boundingBox?.top ?? 0.0) <= imageHeight * 0.5)
           .map((Barcode barcode) => _changeBarcodeType(barcode))
           .where((String? barcode) => barcode?.isNotEmpty == true)
           .cast<String>()