Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clock render uses setInterval not requestAnimationFrame #135

Closed
notrodes opened this issue Aug 28, 2020 · 1 comment · Fixed by #151
Closed

Clock render uses setInterval not requestAnimationFrame #135

notrodes opened this issue Aug 28, 2020 · 1 comment · Fixed by #151
Labels
frontend Suspected problem with frontend (client-side code in public directory) good first issue Good for newcomers

Comments

@notrodes
Copy link
Collaborator

clock.js line 19
@notrodes notrodes added frontend Suspected problem with frontend (client-side code in public directory) good first issue Good for newcomers labels Aug 28, 2020
@notrodes
Copy link
Collaborator Author

probably request animation frame in a set interval.

@andOrlando andOrlando mentioned this issue Oct 26, 2020
Merged
psvenk pushed a commit that referenced this issue Oct 26, 2020
@andOrlando
requestAnimationFrame update for clock (#151)
de3a701 
Switches setInterval to requestAnimationFrame (closes #135).
andOrlando added a commit that referenced this issue Dec 16, 2020
@andOrlando
requestAnimationFrame update for clock (#151)
81b3fed 
Switches setInterval to requestAnimationFrame (closes #135).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
frontend Suspected problem with frontend (client-side code in public directory) good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

requestAnimationFrame update for clock andOrlando/aspine
1 participant
@notrodes