Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dark Mode Update Realtime #235

Closed
kdk1616 opened this issue Dec 28, 2020 · 0 comments · Fixed by #237
Closed

Dark Mode Update Realtime #235

kdk1616 opened this issue Dec 28, 2020 · 0 comments · Fixed by #237
Assignees
@psvenk
Labels
bug Something isn't working frontend Suspected problem with frontend (client-side code in public directory)
Milestone
2.6.2

Comments

@kdk1616
Copy link
Collaborator

kdk1616 commented Dec 28, 2020

Aspine only sets enables/disables dark mode based on the devices state when it loads the page

  • When the mode of a device is toggled after the site has already been loaded, Aspine doesn't respond
  • This is particularly important on mobile where there is no slider
  • Add an event listener? so that it can respond
@psvenk psvenk added bug Something isn't working frontend Suspected problem with frontend (client-side code in public directory) good first issue Good for newcomers and removed good first issue Good for newcomers labels Dec 28, 2020
@psvenk psvenk self-assigned this Dec 28, 2020
@psvenk psvenk mentioned this issue Dec 28, 2020
Merged
@psvenk psvenk added this to the 2.7.0 milestone Dec 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@psvenk psvenk

Labels
bug Something isn't working frontend Suspected problem with frontend (client-side code in public directory)
Projects
None yet
Milestone
2.6.2
Development

Successfully merging a pull request may close this issue.

Update dark mode in real time Aspine/aspine
2 participants
@kdk1616 @psvenk