Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dark mode in real time #237

Merged
merged 1 commit into from
Dec 28, 2020
Merged

Update dark mode in real time #237

merged 1 commit into from
Dec 28, 2020

Conversation

psvenk
Copy link
Member

@psvenk psvenk commented Dec 28, 2020

Closes #235. Use an event listener to update dark/light mode on the fly when the user changes their operating system setting and has not expressed a preference in localStorage.

Use an event listener to update dark/light mode on the fly when the user
changes their operating system setting and has not expressed a
preference in localStorage.
Copy link
Collaborator

@jadebuckwalter jadebuckwalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I was actually wondering about this issue earlier while working on dark mode, so I'm glad you were able to fix it.

@psvenk psvenk merged commit 18eb96e into master Dec 28, 2020
@psvenk psvenk deleted the dark-mode-update branch December 28, 2020 02:33
@psvenk psvenk added this to the 2.7.0 milestone Dec 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dark Mode Update Realtime
2 participants