Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change build-lite.sh to POSIX sh syntax #121

Merged
merged 1 commit into from
May 24, 2020
Merged

Change build-lite.sh to POSIX sh syntax #121

merged 1 commit into from
May 24, 2020

Conversation

psvenk
Copy link
Member

@psvenk psvenk commented May 4, 2020

This should solve incompatibilities with non-GNU systems.

@kdk1616, would you check if this works on macOS?

Windows (without Cygwin/MSYS/WSL) is not supported.

@psvenk psvenk requested review from kdk1616 and Ruborcalor May 4, 2020 18:21
@psvenk
Copy link
Member Author

psvenk commented May 5, 2020

The script works flawlessly on a clean install of OpenBSD, but I think macOS uses outdated versions of BSD utilities, so @kdk1616's testing will still be valuable.

@psvenk psvenk force-pushed the fix-build-lite branch from fbca634 to dfd22db Compare May 6, 2020 22:20
@psvenk
Copy link
Member Author

psvenk commented May 6, 2020

I wanted to test with the old version of Bash included in macOS, but apparently it is from 2006 and predates Node.js. It seems that I will need to scp the node_modules directory...

@psvenk
Copy link
Member Author

psvenk commented May 6, 2020

Works on Ubuntu 7.04.

This should solve incompatibilities with non-GNU systems (tested on
macOS and OpenBSD).

Co-authored-by: kdk1616 <31357347+kdk1616@users.noreply.github.com>
@psvenk psvenk merged commit 9050ea2 into master May 24, 2020
@psvenk psvenk deleted the fix-build-lite branch May 24, 2020 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants