Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve formatting and text on login page #158

Closed
wants to merge 2 commits into from
Closed

Improve formatting and text on login page #158

wants to merge 2 commits into from

Conversation

MohanMaker
Copy link
Collaborator

@MohanMaker MohanMaker commented Oct 30, 2020

In my opinion, the login page looks a bit cluttered with too many lines of text and weird text padding, spacing, and margins. This pull request aims to clean up the login page by reducing the amount of text (everything is still there though), and tweaking some of the spacings. I have attached two comparison images below. I believe it looks better than before, but I understand that this is subjective so am open to feedback! I have also tested the new design on mobile using Safari developer tools and it looks good there too. (Side note: in a separate commit I also changed the message when you edit assignments since it was confusing.)

Old Format (below)
Screen Shot 2020-10-30 at 7 22 12 PM

New Format (below)
Screen Shot 2020-10-30 at 7 23 01 PM

@MohanMaker
Copy link
Collaborator Author

MohanMaker commented Nov 4, 2020

To work on:

  • Add reference to email if you want to get involved in the project (closes Gently emphasize on login page that we are accepting contributions #142).
    <a href = "mailto: crls-ctf-club-usergroup@cpsd.us">"Join Aspine/CTF club (email)</a>
  • Switch wording to "Aspen credentials or leave blank to import data"
  • Change the message when editing assignments to "enter the percentage of lost points which are redeemable"
  • Instead of using colons in the links at the bottom, make all of the text into a link. Remove the CPSD from privacy policy.
  • Change "Open source code" to "Open source project"
  • Remove the question mark in "Remember Me?"
  • Change how you import data. Make it so you can click on the words input data to import it rather than having to leave the sign-in field blank.
  • Format things centered vs left?
  • Add some of this info in the info tab and on the bottom of the home page.
  • Hovering over icons

@psvenk psvenk linked an issue Nov 5, 2020 that may be closed by this pull request
@MohanMaker MohanMaker marked this pull request as draft November 12, 2020 14:07
@MohanMaker
Copy link
Collaborator Author

Closing since I can't figure out how to make changes to the commits. Will open a new one with the new changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gently emphasize on login page that we are accepting contributions
1 participant